Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable docker CLI hints, fixes #5077 #5085

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 5, 2023

The Issue

How This PR Solves The Issue

Turn off cli hints with environment variable DOCKER_CLI_HINTS=false

Manual Testing Instructions

ddev poweroff && docker rmi -f $(docker images -q) && ddev start

@rfay rfay requested a review from a team as a code owner July 5, 2023 13:47
@github-actions github-actions bot added the bugfix label Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Copy link
Member

@gilbertsoft gilbertsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are never interested in these hints, isn't it? So why not set this variable always and not only for pull?

@rfay
Copy link
Member Author

rfay commented Jul 5, 2023

It could definitely be done in root.go or a.go. I tried to put it in DockerEnv() and didn't work there.

@rfay
Copy link
Member Author

rfay commented Jul 5, 2023

Moved to a.go

@rfay rfay requested a review from gilbertsoft July 5, 2023 18:03
Copy link
Member

@gilbertsoft gilbertsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rfay rfay merged commit ff19fa9 into ddev:master Jul 6, 2023
21 checks passed
@rfay rfay deleted the 20230705_disable_docker_hints branch July 6, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants