fix: revert accidental change of upload-dir type, fixes #5076 #5087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
The type of the
upload-dir
flag was accidentially changed to string slice.How This PR Solves The Issue
This PR reverts the accidental change back to type string which will make
--upload-dir
working again like expected.Manual Testing Instructions
ddev config --project-type=craftcms --docroot=web --create-docroot --upload-dir=cpresources
should properly add thecpresources
to theupload_dirs
config.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes