Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: reduce Homebrew cleanup #5088

Merged
merged 3 commits into from
Jul 6, 2023
Merged

ci: reduce Homebrew cleanup #5088

merged 3 commits into from
Jul 6, 2023

Conversation

gilbertsoft
Copy link
Member

@gilbertsoft gilbertsoft commented Jul 5, 2023 •
edited by gitpod-io bot

brew upgrade makes too much noise and takes too long, skip for now.

@gilbertsoft gilbertsoft requested a review from a team as a code owner July 5, 2023 19:50
@gilbertsoft gilbertsoft changed the title ci: reduce Homebrew cleanup [skip ci] ci: reduce Homebrew cleanup Jul 5, 2023
@gilbertsoft
Copy link
Member Author

Don't skip ci for this one, we like to have a full run to see if Colima works now.

rfay
rfay approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again willing to try it! let's look at the actual output and make sure it's doing as little as possible

rfay
rfay requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a mistake that we're not running tests on this. We must have something configured wrong.

@rfay
Copy link
Member

rfay commented Jul 5, 2023

Oh, it's because the skip ci on the commit itself.

@rfay
Copy link
Member

rfay commented Jul 5, 2023

Let's remove the skip ci (do another commit) and at least see the tests start to work.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023 •
edited

Download the artifacts for this pull request:

See Testing a PR

@rfay rfay merged commit 7eed434 into ddev:master Jul 6, 2023
23 checks passed
@rfay rfay deleted the ci/reduce-brew-cleanup branch July 6, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay requested changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gilbertsoft @rfay