Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: prevent job from failing if cleanup fails #5097

Merged
merged 1 commit into from
Jul 10, 2023
Merged

ci: prevent job from failing if cleanup fails #5097

merged 1 commit into from
Jul 10, 2023

Conversation

gilbertsoft
Copy link
Member

@gilbertsoft gilbertsoft commented Jul 7, 2023 •
edited by gitpod-io bot

The Issue

Cleanup may fail on upstream problems see https://github.com/ddev/ddev/actions/runs/5482145525/jobs/9987195573?pr=5094

How This PR Solves The Issue

Make clean up optional and don't fail anymore.

@gilbertsoft gilbertsoft requested a review from a team as a code owner July 7, 2023 07:29
@gilbertsoft gilbertsoft mentioned this pull request Jul 7, 2023
Merged
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Download the artifacts for this pull request:

See Testing a PR

rfay
rfay approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Might be clearer and better with brew autoremove || true etc. Then we're relying on explicit "don't worry about it" commands rather than relying on Github's directives. Both ways should be fine.

@gilbertsoft
Copy link
Member Author

This seems fine. Might be clearer and better with brew autoremove || true etc. Then we're relying on explicit "don't worry about it" commands rather than relying on Github's directives. Both ways should be fine.

|| true is a bad idea because it hides the failure but we like to continue on failures but still see if failures occur which also can mean we have to optimize the workflow again.

@rfay rfay merged commit 0acea6e into ddev:master Jul 10, 2023
27 checks passed
@rfay rfay deleted the ci/do-not-fail-on-cleanup branch July 10, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gilbertsoft @rfay