Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ddev-webserver process kill function was incorrect #5107

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: ddev-webserver process kill function was incorrect #5107

merged 1 commit into from
Jul 10, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 8, 2023 •
edited by gitpod-io bot

The Issue

During debugging we saw:

2023-07-07 20:47:42,159 INFO stopped: child_exit_monitor (terminated by SIGTERM)
+ trap - SIGTERM
+ kill -- --1
/pre-start.sh: line 1: kill: --1: arguments must be process or job IDs

Apparently in the situation of a failing web_extra_daemon things weren't handled correctly.

How This PR Solves The Issue

Use the correct syntax, kill -- -1 (-1 rather than --1)

Manual Testing Instructions

The previous error was created by making an error happen with something like this:

  web_extra_daemons:
    - name: "failit"
      command: "./failit.sh"
      directory: /var/www/html

and after ddev start, ddev logs showed the error.

This shouldn't happen now.

@rfay rfay mentioned this pull request Jul 8, 2023
Closed
@github-actions github-actions bot added bugfix dependencies Pull requests that update a dependency file labels Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

Download the artifacts for this pull request:

See Testing a PR

@rfay rfay marked this pull request as ready for review July 9, 2023 12:30
@rfay rfay requested a review from a team as a code owner July 9, 2023 12:30
@rfay rfay merged commit f39c884 into ddev:master Jul 10, 2023
28 checks passed
@rfay rfay deleted the 20230707_fix_process_group_kill branch July 10, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbertsoft gilbertsoft gilbertsoft approved these changes

Assignees
No one assigned
Labels
bugfix dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rfay @gilbertsoft