refactor: revert upload_dirs=false, fixes #5131
#5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
changed the title
1 task
rfay
changed the title
upload_dirs=false, fixes #5131
gilbertsoft
requested changes
Jul 14, 2023
| util.Warning("You have Mutagen enabled and your '%s' project type doesn't have `upload_dirs` set.", app.Type) | ||
| util.Warning("For faster startup and less disk usage, set upload_dirs to where your user-generated files are stored.") | ||
| util.Warning("If this is intended you can disable this warning by running `ddev config --upload-dirs=false`.") | ||
| // TODO: Implement --no-upload-dirs-warning in new PR | ||
| util.Warning("If this is intended you can disable this warning with `ddev config --no-upload-dirs-warning`.") |
There was a problem hiding this comment.
Suggested change
| util.Warning("If this is intended you can disable this warning with `ddev config --no-upload-dirs-warning`.") | |
| //util.Warning("If this is intended you can disable this warning with `ddev config --no-upload-dirs-warning`.") |
does not make much sense to show this info even it doesn't work at the moment
There was a problem hiding this comment.
I'm going to follow it immediately with the actual replacement, so it's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
We tried to support a multi-type upload_dirs but it added a lot of complexity to the code.
Unfortunately, I've decided to revert that and go back to a simpler approach.
An additional PR will be required to add a new config that turns off warnings about upload_dirs
Also accidentally fixes
config.*.yamlresets upload_dirs to empty #5131by going back to a simple array for the declaration.
How This PR Solves The Issue
Manual Testing Instructions
Many things have to be re-tested:
config.*.yamlresets upload_dirs to empty #5131 - emptyconfig.*.yamlwas resulting in upload_dirs being emptiedddev import-filesshould work any time upload_dirs are implied or specified #5127 - import-files needs to work on Laravel and Craft if import-dirs specifiedupload-dirsis false #5126 - panic with upload-dirsupload_dirshould be able to be set to empty to prevent bind-mounting #4796 - Of course we need a way to do that.Automated Testing Overview
I think the tests cover the things that matter
Related Issue Link(s)
Release/Deployment Notes