refactor: start reporting all commands to amplitude #5136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
changed the title
|
Download the artifacts for this pull request:
See Testing a PR |
|
Tested this out and it seems to be working fine. |
1 task
rfay
added a commit
that referenced
this pull request
Jul 18, 2023
…skip ci]" This reverts commit ba445cf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Code said we were supposed to start reporting other commands to Amplitude by now
How This PR Solves The Issue
Remove the exclusions
Manual Testing Instructions
Look at Amplitude data coming in.
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes