refactor: add sendmail -t flag to mailhog call for symfony/mailer native transport compat, fixes #4363

[rfay]

The Issue

This PR replaces

• refactor: add -t flag to mailhog call for symfony/mailer native transport compat, fixes #4363 #5138 by @rodrigoaguilera

Will make sure you get commit credit for it. I couldn't push the image spec into your PR.

• Add compatibility between symfony mailer and php sendmail_path configuration for mailhog #4363

How This PR Solves The Issue

Add a harmless -t to the mailhog call

Manual Testing Instructions

Automated Testing Overview

Mailhog integration is not tested AFAIK and soon will be replaced by mailpit

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR

[rfay]

This obviously isn't urgent so I'll wait for testing responses and it will wait until after v1.22.0 is out.

[rodrigoaguilera]

No hurry of course.

My testing steps:

• First I reproduced the issue on ddev 1.21.6, Drupal 10.1.1 and drupal/symfony_mailer 1.3.0-rc2.
• I installed a fresh debian 12 with the ddev from the PR and the same fresh Drupal 10.1.1 projects
• Verified that it was using the 20230716_rodrigoaguilera_sendmail_t docker image
• Without installing symfony mailer I verified that mailhog captures the reset password email
• Installed symfony mailer and sent a test email from its interface that was captured by mailhog
• Created a zero-configuration native mail transport and set it as default
• Sent another test email with no errors and it was captured by mail so the bug is fixed.
• Verified the -t flag is not only set for php-fpm but for php-cli also.

This change is good to be included from my testing. Thanks for fixing the PR and uploading the images.

Additional testing

• Removed the symfony_mailer overrides from settings.ddev.php and tried the default "Sendmail" transport but unfortunately it doesn't use what is set on sendmail_path but it is hardcoded to use the binary sendmail -bs.

[rfay]

So @rodrigoaguilera as far as you're concerned this is ready?

May still need some "ordinary" testing.

[rodrigoaguilera]

I still have the fresh debian 12 machine around with the PR installed so I cloned two of my clients Drupal projects. One of them has nightwatch tests that send emails and they all came green. This project uses the symfony_mailer and the tests check that emails are received in mailhog.
For the other project I did the usual checks as when I deploy to production and more tests around mail sending: cron notifications and newsletter subscription confirmation. All good.

From my side this change is ready.

[rfay]

Rebased, pushed new image.

[rfay]

Thanks so much for chasing this and doing the PR and testing. I tested manually and seemed to be fine.

[rodrigoaguilera]

Thanks to you for maintaining an awesome piece of software