Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default_container_timeout should actually work, fixes #5133 #5154

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: default_container_timeout should actually work, fixes #5133 #5154

merged 1 commit into from
Jul 18, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Jul 17, 2023 •
edited

The Issue

How This PR Solves The Issue

Actually use the timeout in the docker-compose setup

Manual Testing Instructions

ddev config --default-container-timeout=600
ddev start
ddev snapshot restore huge

Assuming huge snapshot can be imported in 10m, it shouldn't time out or give the timeout message

@github-actions
Copy link

Download the artifacts for this pull request:

See Testing a PR

@rfay rfay mentioned this pull request Jul 17, 2023
Open
1 task
@rfay rfay marked this pull request as ready for review July 17, 2023 18:00
@rfay rfay requested a review from a team as a code owner July 17, 2023 18:00
@rfay rfay merged commit ef71d25 into ddev:master Jul 18, 2023
28 checks passed
@rfay rfay deleted the 20230717_default_container_timeout branch July 18, 2023 21:06
@rfay rfay mentioned this pull request Oct 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rfay