refactor: start with random ticker message, fixes #5180 #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
requested changes
Jul 21, 2023
There was a problem hiding this comment.
If I delete ~/.ddev/.state.yaml and ddev start I get this:
$ ddev start
2023-07-21T11:02:16.319 Downloading remote config.
2023-07-21T11:02:16.732 Error while downloading remote config: invalid character ',' looking for beginning of value
panic: invalid argument to Intn
goroutine 1 [running]:
math/rand.(*Rand).Intn(0x140000dd878?, 0x1054db058?)
/opt/homebrew/Cellar/go/1.20.5/libexec/src/math/rand/rand.go:179 +0x64
math/rand.Intn(...)
/opt/homebrew/Cellar/go/1.20.5/libexec/src/math/rand/rand.go:358
github.com/ddev/ddev/pkg/config/remoteconfig.(*remoteConfig).ShowTicker(0x140004fe000)
/Users/rfay/workspace/ddev/pkg/config/remoteconfig/messages.go:128 +0x70
github.com/ddev/ddev/cmd/ddev/cmd.glob..func57(0x105927080?, {0x10596e278, 0x0, 0x0})
/Users/rfay/workspace/ddev/cmd/ddev/cmd/start.go:64 +0x284
github.com/spf13/cobra.(*Command).execute(0x105927080, {0x10596e278, 0x0, 0x0})
/Users/rfay/workspace/ddev/vendor/github.com/spf13/cobra/command.go:944 +0x5b0
github.com/spf13/cobra.(*Command).ExecuteC(0x1059256a0)
/Users/rfay/workspace/ddev/vendor/github.com/spf13/cobra/command.go:1068 +0x35c
github.com/spf13/cobra.(*Command).Execute(...)
/Users/rfay/workspace/ddev/vendor/github.com/spf13/cobra/command.go:992
github.com/ddev/ddev/cmd/ddev/cmd.Execute()
/Users/rfay/workspace/ddev/cmd/ddev/cmd/root.go:171 +0x28
main.main()
/Users/rfay/workspace/ddev/cmd/ddev/main.go:28 +0xb8
I note that I'm also pointing to an invalid jsonc,
remote_config:
remote:
owner: rfay
repo: remote-config
ref: broken
filepath: remote-config.jsonc
|
The panic should be solved by 6742995 |
rfay
approved these changes
Jul 21, 2023
rfay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
On short living instances e.g. Gitpod the first ticker message is always show.
How This PR Solves The Issue
In case no message was shown so far, a random message is picked.
Manual Testing Instructions
Remove the state file
~/.ddev/.state.yamland check if a random message is shown onddev start.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes