Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: traefik dashboard should not bind all interfaces by default #5185

Merged
merged 1 commit into from
Jul 22, 2023
Merged

fix: traefik dashboard should not bind all interfaces by default #5185

merged 1 commit into from
Jul 22, 2023

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Jul 22, 2023

The Issue

There is no difference in router_bind_all_interfaces for Traefik:

ddev config global --router-bind-all-interfaces=true
ddev start
cat ~/.ddev/.router-compose.yaml | grep 9999
    - 9999:9999

ddev config global --router-bind-all-interfaces=false
ddev start
cat ~/.ddev/.router-compose.yaml | grep 9999
    - 9999:9999

How This PR Solves The Issue

Traefik must consider the router_bind_all_interfaces config.

Manual Testing Instructions

ddev config global --router-bind-all-interfaces=false
ddev start
cat ~/.ddev/.router-compose.yaml | grep 9999
    - "127.0.0.1:9999:9999"

ddev config global --router-bind-all-interfaces=true
ddev start
cat ~/.ddev/.router-compose.yaml | grep 9999
    - "9999:9999"

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner July 22, 2023 10:13
@github-actions
Copy link

@stasadev stasadev changed the title fix: traefik should not bind all interfaces by default fix: traefik dashboard should not bind all interfaces by default Jul 22, 2023
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right! Thanks for chasing this down. After all those months it's been in the wild :)

@rfay
Copy link
Member

rfay commented Jul 22, 2023

Manually tested, works exactly as it should, thanks!

@rfay rfay merged commit 8163829 into ddev:master Jul 22, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants