fix: provide consistent hash per drupal/backdrop project name, fixes #5255 #5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
|
I applied the fix, and it seemed to work well in my environment. Thanks @rfay! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
ddev startalways creates a new hash_salt in settings.ddev.php (Drupal); should be static. #5255Creating a new hash on restart can cause a number of Drupal/Backdrop functions to misbehave
How This PR Solves The Issue
The hash is now calculated based on the project name. This is inappropriate for production, but should work great for developer situations. It also means that the hash will be the same for all developers on a team.
Manual Testing Instructions
ddev startmultiple times and review thesettings.ddev.phpfor the project. It should not change, but should be different for different projects.Automated Testing Overview
Added TestDrupalBackdropConsistentHash