fix: add dedicated ddev-traefik-router, fixes #5239, fixes #5209 #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bugfix
dependencies
|
Download the artifacts for this pull request:
See Testing a PR |
mattstein
requested changes
Aug 17, 2023
gilbertsoft
approved these changes
Aug 17, 2023
Co-authored-by: Matt Stein <m@ttste.in>
Co-authored-by: Gilbertsoft <25326036+gilbertsoft@users.noreply.github.com>
rfay
force-pushed
the
20230816_traefik_image
branch
from
0d7df46
to
ab13f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
apkfailing building Traefik router (VPN) #5209In DDEV v1.22.0 the default router was changed to traefik, and a build stage was added. There were a couple of side-effects in unusual cases in the above issues.
How This PR Solves The Issue
Switch to a pre-built ddev-traefik-router image so we have control of the build process.
Manual Testing Instructions
Automated Testing Overview