codespaces - remove docker-in-docker since it's installed via universal image

[mandrasch]

The Issue

• it was explained here, that the universal image already installs docker-in-docker Docker-in-docker: Add retry mechanism into the docker init script (Failed to connect to Docker) devcontainers/features#634 (comment)

• docker-in-docker feature had no effect and lead to irritating output, since the outputted version info in codespaces creation log had no real effect (since docker was already installed)

• updated my demo repo https://github.com/mandrasch/ddev-craftcms-vite/blob/main/.devcontainer/devcontainer.json#L4, first tests worked

• We might discuss whether ddev itself should be tested with universal image as well?

  ddev/.devcontainer/devcontainer.json

  Lines 2 to 14 in 56afe4b

  	// README at: https://github.com/devcontainers/templates/tree/main/src/go
  	{
  	"name": "Go",
  	// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
  	"image": "mcr.microsoft.com/devcontainers/go:0-1-bullseye",
  	"features": {
  	"ghcr.io/devcontainers/features/docker-in-docker:2": {},
  	"ghcr.io/rocker-org/devcontainer-features/apt-packages:1": {
  	"packages": "autojump,curl,wget,xdg-utils"
  	},
  	"ghcr.io/eitsupi/devcontainer-features/jq-likes:1": {},
  	"ghcr.io/edouard-lopez/devcontainer-features/bats:0": {}
  	},

  (don't know about ramifications, just a quick idea)

How This PR Solves The Issue

• updating the docs, removing docker-in-docker from code snippet

Manual Testing Instructions

• Ran mkdocs locally

Automated Testing Overview

• no automated test option for codespaces available

Related Issue Link(s)

• Docker-in-docker: Add retry mechanism into the docker init script (Failed to connect to Docker) devcontainers/features#634 (comment)
• frontend website https://ddev.com/get-started/ --> codespaces also needs an update, open ticket / PR

Release/Deployment Notes

no

[rfay]

Would you mind adding these changes to the DDEV devcontainer.json as well?

[mandrasch]

Would you mind adding these changes to the DDEV devcontainer.json as well?

Sure thing, very happy to try it! :-)

I'll try with the universal image (and without docker-in-docker as extra feature) in the next days:

        "image": "mcr.microsoft.com/devcontainers/universal:2",
 	"features": { 
 		"ghcr.io/rocker-org/devcontainer-features/apt-packages:1": { 
 			"packages": "autojump,curl,wget,xdg-utils" 
 		}, 
 		"ghcr.io/eitsupi/devcontainer-features/jq-likes:1": {}, 
 		"ghcr.io/edouard-lopez/devcontainer-features/bats:0": {} 
 	}, 

[mandrasch]

Updated the devcontainer.json accordingly.

Creating a new codespace instance with it ran through successfully, I could also open the example project in /workspaces/d9simple/. ✅

One slight hiccup occured when the codespace instance was automatically paused, after the restart docker was not up and running. After turning it off and on again everything worked again. Most probably not a DDEV-related issue, just a codespace one.

Tried another manual restart as well, all worked fine.

[rfay]

Thanks!

[rfay]

Universal also contains golang and make, all we need.