fix: re-add DDEV_MAILHOG_PORT and related env vars, fixes #5351 #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
force-pushed
the
20230918_5351_support_mailhog_env_vars
branch
from
59c34f6
to
dfbb333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
In DDEV v1.22.2 we removed DDEV_MAILHOG_PORT and that made a number of usages fail. Putting that back; it now points to mailpit of course.
Manual Testing Instructions
Automated Testing Overview
We now test for DDEV_MAILHOG_PORT and several other things.
Related Issue Link(s)
Release/Deployment Notes