Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: we shouldn't show the amplitude warning on every ddev command #5471

Merged
merged 3 commits into from Oct 29, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Oct 28, 2023

The Issue

When ddev has been compiled without AmplitudeAPIKey (as with brew install --HEAD ddev it shows a message warning about the situation.

However, it has been going overboard in recent versions, showing it on every command. Change it to warn only on ddev start.

The message is:

Instrumentation is opted in, but AmplitudeAPIKey is not available. This usually means you have a locally-built ddev binary or one from a PR build. It's not an error. Please report it if you're using an official release build.

Manual Testing Instructions

unset AmplitudeAPIKey
make
ddev config global --instrumentation-opt-in=true
cd <someproject>
ddev start 
ddev exec ls 

The message should show at the end of ddev start but not on ddev exec.

Automated Testing Overview

No changes.

@github-actions
Copy link

github-actions bot commented Oct 28, 2023

@rfay rfay marked this pull request as ready for review October 29, 2023 23:49
@rfay rfay requested a review from a team as a code owner October 29, 2023 23:49
@rfay rfay merged commit 7b4eacf into ddev:master Oct 29, 2023
21 checks passed
@rfay rfay deleted the 20231028_amplitude_warning_only_on_start branch October 29, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant