Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: always use the latest go and golangci-lint for gitpod [skip ci] #5481

Merged
merged 2 commits into from Oct 30, 2023

Conversation

stasadev
Copy link
Member

The Issue

It is easy to forget to update some packages in Dockerfile for Gitpod after release.

How This PR Solves The Issue

Try to use the latest version all the time.

Found the solution for go here.
And it was super easy for golangci-lint - I just removed the hard-coded version.

Manual Testing Instructions

$ docker buildx build -t ddev/ddev-gitpod-base --platform=linux/amd64 .gitpod/images

$ docker run --rm -it ddev/ddev-gitpod-base go version
go version go1.21.3 linux/amd64

$ docker run --rm -it ddev/ddev-gitpod-base golangci-lint version
golangci-lint has version 1.55.1 built with go1.21.3 from 9b20d49d on 2023-10-25T10:03:43Z

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner October 30, 2023 19:17
@stasadev stasadev changed the title build: always use the latest go and golangci-lint [skip ci] build: always use the latest go and golangci-lint for gitpod [skip ci] Oct 30, 2023
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as good as it gets! Thanks!

@rfay
Copy link
Member

rfay commented Oct 30, 2023

Followup will be to push a new version of the image, probably with a new tag, and update here and in ddev-gitpod-launcher. I think it would be OK to push now and add the new tag to this PR.

@stasadev stasadev merged commit 49ae582 into ddev:master Oct 30, 2023
4 checks passed
@stasadev stasadev deleted the 20231030_stasadev_gitpod_latest branch October 30, 2023 20:06
@stasadev
Copy link
Member Author

Pushed a new tag and updated it here and in ddev-gitpod-launcher.

@rfay
Copy link
Member

rfay commented Oct 30, 2023

gitpod /workspace/ddev (master) $ go version && ddev --version
go version go1.21.3 linux/amd64
ddev version v1.22.4

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants