docs: allow uppercase letters on pr titles. #5514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
reviewed
Nov 8, 2023
| @@ -19,7 +19,7 @@ jobs: | |||
| - name: Check Type | |||
| uses: gsactions/commit-message-checker@v2 | |||
| with: | |||
| pattern: '^(build|ci|docs|feat|fix|refactor|test)(|!): [a-z].+?((, fixes #\d+)*)($|\n|\r|\n\r)' | |||
| pattern: '^(build|ci|docs|feat|fix|refactor|test)(|!): [A-Za-z].+?((, fixes #\d+)*)($|\n|\r|\n\r)' | |||
There was a problem hiding this comment.
Looks right to me. Can you test it on your fork?
There was a problem hiding this comment.
Don't forget to change the docs with this.
There was a problem hiding this comment.
Well, the docs already match this pattern since they ask for the first letter to be an uppercase.
It would be tricky to test it maybe as a post-commit hook but that be a bit different.
There was a problem hiding this comment.
Oh, didn't even realize that was the reason for your other PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Allows the PR title to hold an uppercase.
relates #5502
How This PR Solves The Issue
It changes the regular expression to allow uppercase letters.