fix: allow editing for platform.yaml #5515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stasadev
force-pushed
the
20231108_stasadev_platform_yaml
branch
from
ce11811
to
fde8aa9
Compare
stasadev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
When testing Upsun, I copied the
platform.yamland checked its settings.When I wanted to customize it, I removed the
#ddev-generatedline and randdev restart, but the file was reset.That's because there is a second
#ddev-generatedin this file.How This PR Solves The Issue
Removes
#from the extra#ddev-generated.Removes an extra line at the end of the file.
Adds a space between
#set -x- to make it look like others# set -xin this file.Manual Testing Instructions
ddev start.ddev/providers/platform.yaml- remove the#ddev-generatedfrom the top.ddev stop- see that file is reset..ddev/providers/platform.yaml- remove the#ddev-generatedfrom the top and edit the second entry of#ddev-generatedon the third line toddev-generatedddev start- see that file is not reset.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes