Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow testcmd to run as make tarket on pull-push-test-platforms, follow up to #5516 #5517

Merged
merged 1 commit into from Nov 9, 2023
Merged

fix: allow testcmd to run as make tarket on pull-push-test-platforms, follow up to #5516 #5517

merged 1 commit into from Nov 9, 2023

Conversation

hanoii
Copy link
Collaborator

@hanoii hanoii commented Nov 9, 2023

On #5516 we added the test, but it didn't run because testcmd was not part of the make target.

@hanoii hanoii requested a review from a team as a code owner November 9, 2023 02:36
rfay
rfay approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, right thing to do, thanks.

@rfay rfay merged commit 4932337 into ddev:master Nov 9, 2023
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanoii @rfay