fix: build new ddev-webserver to get fixed lagoon-sync, rework Acquia for #4760 #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bugfix
dependencies
|
Download the artifacts for this pull request:
See Testing a PR |
rfay
changed the title
rfay
changed the title
1 task
rfay
changed the title
|
This didn't actually run the tests because it runs the tests from upstream/master, so doesn't show the actual results, but review requested anyway. Seemed to run OK locally. |
rfay
force-pushed
the
20231108_new_lagoon
branch
from
82464c2
to
dbbde17
Compare
stasadev
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Also rework acquia integration
How This PR Solves The Issue
Update ddev-webserver with fresh working lagoon-sync
Update Acquia integration for acli
Stop needing to edit the acquia integration
Manual Testing Instructions
ddev pull lagoon -y --skip-dbddev pull acquia -yAutomated Testing Overview
Related Issue Link(s)
Release/Deployment Notes
This is a massive change to acquia integration, so that will have to be pointed out in release notes.