Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check for duplicate networks, for #5508 #5541

Merged
merged 2 commits into from Nov 18, 2023

Conversation

stasadev
Copy link
Member

The Issue

How This PR Solves The Issue

Docker networks can be created programmatically with the same name (this is no longer possible with Docker >=25.x.x):

This test creates two networks with the same name, removes duplicates, and checks that everything is OK.

Manual Testing Instructions

Automated Testing Overview

See TestNetworkDuplicates

Related Issue Link(s)

Release/Deployment Notes

Copy link

github-actions bot commented Nov 15, 2023

@stasadev stasadev force-pushed the 20231115_stasadev_test_duplicate_networks branch from 86f494f to 5b54e8e Compare November 16, 2023 17:41
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rfay rfay merged commit c75097b into ddev:master Nov 18, 2023
14 of 16 checks passed
@stasadev stasadev deleted the 20231115_stasadev_test_duplicate_networks branch November 20, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants