fix: php8.3 should allow environment variables to php-fpm #5573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
@rpkoller and I were studying the failure of Drupal 10 to install and we discovered a regresssion - $IS_DDEV_PROJECT was not available to settings.php, meaning that it didn't behave correctly and load settings.ddev.php.
The problem was that the PHP8.3 fpm/pool.d/www.conf didn't have the correct setting for
clear_env
, which should be "no" for DDEVHow This PR Solves The Issue
Manual Testing Instructions
Do a Drupal10 installation with php8.3, it should work.
Automated Testing Overview
Coverage of this regression was added in TestPHPConfig
Related Issue Link(s)
Release/Deployment Notes