Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: php8.3 should allow environment variables to php-fpm #5573

Merged
merged 10 commits into from Nov 27, 2023

Conversation

rfay
Copy link
Member

@rfay rfay commented Nov 26, 2023

The Issue

@rpkoller and I were studying the failure of Drupal 10 to install and we discovered a regresssion - $IS_DDEV_PROJECT was not available to settings.php, meaning that it didn't behave correctly and load settings.ddev.php.

The problem was that the PHP8.3 fpm/pool.d/www.conf didn't have the correct setting for clear_env, which should be "no" for DDEV

How This PR Solves The Issue

  • Set it correctly
  • Also noted another change from php8.2 that was not intentional, daemonize = no and catch_workers_output=yes
  • Added test to make sure we get environment variables

Manual Testing Instructions

Do a Drupal10 installation with php8.3, it should work.

Automated Testing Overview

Coverage of this regression was added in TestPHPConfig

Related Issue Link(s)

Release/Deployment Notes

@github-actions github-actions bot added bugfix dependencies Pull requests that update a dependency file labels Nov 26, 2023
Copy link

@rpkoller
Copy link
Collaborator

rpkoller commented Nov 26, 2023

I've tested with the same ansible setup i've previously noticed the issue with. with the downloaded artifact i was able to install a site and the settings.ddev.php was found and the database credentials inside the settings.ddev.php available to the drupal install on php8.3.

@rfay rfay marked this pull request as ready for review November 27, 2023 00:18
@rfay rfay requested a review from a team as a code owner November 27, 2023 00:18
@rfay rfay merged commit b396c9d into ddev:master Nov 27, 2023
25 checks passed
@rfay rfay deleted the 20231126_php8.3_fix branch November 27, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants