ci: don't set default context to default - fix rancher desktop failures #5577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
changed the title
|
I guess we should leave rancher desktop running on PRs for now because otherwise it's too hard to study |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Multiple failures of rancher-desktop tests (see https://github.com/ddev/maintainer-info/issues/1#issuecomment-1828804959) have resulted in the docker context being left as "default" but the default context isn't wired to any provider. Orbstack and Docker Desktop both claim "default", but Rancher Desktop doesn't.
Rancher Desktop also deletes its context when you shut it down, unlike orbstack and Docker Desktop.
How This PR Solves The Issue
Manual Testing Instructions
We'll see if this works.
This temporarily allows rancher to run on this PR, but that should be removed before pulling