fix: disable Xdebug for composer command, fixes #4219
#5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
stasadev
changed the title
composer command, fixes #4219
rfay
force-pushed
the
20231129_stasadev_disable_xdebug_for_composer
branch
from
a89b644
to
54001fb
Compare
|
Rebased |
rfay
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
ddev composershould disable XDebug #4219How This PR Solves The Issue
Adds
XDEBUG_MODE=offforddev composer.os.Setenv("XDEBUG_MODE", "off")is not working here, becauseddev composerruns insidedocker-compose exec.Manual Testing Instructions
ddev startddev xdebugddev composer -V- should not show Xdebug output.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes