docs: GitHub Codespaces: Adjust examples to make sure docker is running

[eiriksm]

The Issue

I was trying to follow the guide and something has probably changed in codespaces since then. I found postAttachCommand works though

How This PR Solves The Issue

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

[rfay]

@mandrasch could you review this please?

[rfay]

Failed spellcheck due to postAttachCommand

[mandrasch]

Hi, thanks for contribution!

As posted in Discord

• postCreateCommand is the correct event in my opinion
• the devcontainer / codespaces team fixed it previously - docker must be available there, otherwise it's a bug in docker-in-docker on their side (universal image)

So please don't remove this from the docs, it's the correct event to install things on first creation of a codespace (e.g. install scripts, etc.)

Saw this in other codespaces demos as well, they all used postCreate

(Scripts / routines would run twice if postAttach is used and the container is opened again as far as I understand - postCreate is really for the first initial steps on a fresh codespace)

Depends on the use case of course - we could add postAttach to the docs as second option?

(Haven't worked with postAttach yet)

Please change PR accordingly if relevant / useful in your opinion :)

Cheers

[rfay]

I'm going to change this to draft status for now; @mandrasch if you can keep us up-to-date with the upstream problem it will be appreciated.

• [docker-in-docker] - Use blocking entrypoints to ensure dockerd startup devcontainers/features#671 (comment)

[eiriksm]

Amazing, thanks! 😍

I'm just glad it's nothing wrong with the docs or ddev, so I just agree with everything said in this thread basically

[mandrasch]

Amazing, thanks! 😍

I'm just glad it's nothing wrong with the docs or ddev, so I just agree with everything said in this thread basically

👍 👍

just fiy: I submitted a new issue here devcontainers/features#780

[mandrasch]

fyi: new comment devcontainers/features#780 (comment)

[rfay]

It does sound like perhaps a new approach is in order @mandrasch ? based on

• Docker not available in postCreateCommand (universal image) devcontainers/features#780 (comment)

[mandrasch]

It does sound like perhaps a new approach is in order @mandrasch ? based on

• Docker not available in postCreateCommand (universal image) devcontainers/features#780 (comment)

yeah... I'll see when I'll find time in the next weeks and I'll post here again. happy travelling in the meantime!

(if anyone else here reading this and wants to try it sooner - please feel free to test the new retry approach 😎)

[eiriksm]

Tested the script and slightly altered it. Seems to work ✌️

[eiriksm]

Updated with new command suggestion. Removed the inline bash example since that must be considered unstable at this point I guess 🤓✌️

[mandrasch]

Awesome work @eiriksm, thanks very much for taking the time to solve this and editing the docs! 👏 🎉 🎉 🎉

(I'll update my demo repo https://github.com/mandrasch/ddev-craftcms-vite in the next days or weeks with your new retry logic 🥳 )

[mandrasch]

Works fine for me, good to go from my point of view! 👍

Thanks very much again!

One last thing: @eiriksm, could you please change the title of your PR?

[eiriksm]

👍done

Thanks for your hard work @mandrasch ♥️

[stasadev]

Thank you!