New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make TestMailpit and TestProjectPortOverride more forgiving of Rancher Desktop, fixes #5578 #5594
Conversation
Download the artifacts for this pull request:
See Testing a PR |
TestProjectPortOverride is also flaky on Rancher at this line, failed here: https://buildkite.com/ddev/macos-rancher-desktop/builds/120#018c22cd-9094-41f8-9452-60e03ce15bcd ddev/pkg/ddevapp/router_test.go Line 116 in 7e872a7
|
This seems to be working OK for TestMailpit at this point. However, TestProjectPortOverride often fails on rancher. It's possible there's something wrong with our test runner[s] and the port is still occupied somehow as well. |
It looks like the healthcheck for traefik may also be checking not-exactly the right thing; it waits for the web server, but that's not the same as all the work being done. We may be able to improve the traefik healthcheck at some point, but 4e58ac2 just tries to give the test a little more time. |
I think it worked! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tests only, so I'm going to go ahead and pull it as it can stop the bleeding on some of the other PRs. We'll still have bleeding on Colima tests though.
If you have things you'd rather do with this @stasadev they're welcome as followup. |
I think it is good enough for tests. |
The Issue
TestMailpit fails intermittently on Rancher Desktop
This may be due to the mailpit API coming up after our healthcheck says it should be ready, because we're not polling the API.
How This PR Solves The Issue
Wait in the test a few seconds if necessary
It's possible this could also be fixed by adding more extensive healthcheck.sh to check the mailpit API, but that seems like overkill for something that is not used a huge amount.