Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add detail about restore command to snapshot command output, fixes #5621 #5622

Merged

Conversation

joachim-n
Copy link
Contributor

The Issue

When you run ddev snapshot, it doesn't tell you how to restore the DB. It's easy to assume you use import-db command, which leads to #5621.

How This PR Solves The Issue

Add to the message output after a snapshot is created to tell the user how to restore snapshots.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@joachim-n joachim-n requested a review from a team as a code owner December 12, 2023 12:07
Copy link

@stasadev stasadev changed the title feat: add detail about restore command to snapshot command output feat: add detail about restore command to snapshot command output, fixes #5621 Dec 12, 2023
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, I can see that it can be confusing even if it is described in the docs and in the ddev help snapshot.

Let's modify it a bit so that users can see the actual command they need to execute.

cmd/ddev/cmd/snapshot.go Outdated Show resolved Hide resolved
@stasadev stasadev merged commit 2c03155 into ddev:master Dec 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants