fix: do not fail on apt-get update for extra packages, for #5620
#5623
Conversation
|
Download the artifacts for this pull request:
See Testing a PR |
pkg/ddevapp/config.go
Outdated
| @@ -1085,8 +1085,8 @@ RUN (groupadd --gid $gid "$username" || groupadd "$username" || true) && (userad | |||
| if extraPackages != nil { | |||
| contents = contents + ` | |||
| ### DDEV-injected from webimage_extra_packages or dbimage_extra_packages | |||
| RUN echo "Disk usage problems: " && df -h /tmp && ls -l /var/lib/apt/lists | |||
| RUN apt-get -qq update && DEBIAN_FRONTEND=noninteractive apt-get -qq install -y -o Dpkg::Options::="--force-confold" --no-install-recommends --no-install-suggests ` + strings.Join(extraPackages, " ") + "\n" | |||
| RUN echo "Disk usage problems: " && df -h / && ls -l /var/lib/apt/lists | |||
There was a problem hiding this comment.
@rfay I'm not sure if we still need this check, if we skip failures for apt-get update, but anyway:
I changed df -h /tmp to df -h / - we discussed this on Discord earlier and df -h /tmp produced less output.
There was a problem hiding this comment.
Agreed we probably won't need it at all, can remove. Install of PHP related packages can still fail, but we have no control. And this check didn't actually do anything but somehow seemed to result in less failures
|
Looks fine to me. I thought maybe there was a second place we do apt update. |
|
There are several |
The Issue
We must not allow
apt-get updateto fail if some repository is down, because it can stop the webserver from starting.How This PR Solves The Issue
Allows
apt-get installto continue after a fail forapt-get update.Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes