Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add quotes for the hostname error for better visibility #5645

Merged
merged 1 commit into from Dec 19, 2023
Merged

refactor: add quotes for the hostname error for better visibility #5645

merged 1 commit into from Dec 19, 2023

Conversation

stasadev
Copy link
Member

The Issue

$ ddev config --project-tld=""
failed to validate config: the test-project project has an invalid hostname: test-project.. See https://en.wikipedia.org/wiki/Hostname#Syntax for valid hostname requirements

It is not clear what hostname is in the error, whether it is test-project. or test-project..

How This PR Solves The Issue

Adds quotes:

$ ddev config --project-tld=""
failed to validate config: the test-project project has an invalid hostname: 'test-project.', see https://en.wikipedia.org/wiki/Hostname#Syntax for valid hostname requirements

@stasadev stasadev requested a review from a team as a code owner December 18, 2023 11:52
@github-actions GitHub Actions
Copy link

Download the artifacts for this pull request:

See Testing a PR

@stasadev stasadev merged commit 66059cf into ddev:master Dec 19, 2023
20 checks passed
@stasadev stasadev deleted the 20231218_stasadev_hostname_error_quotes branch December 19, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@stasadev