Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable Content-Type auto-detection for Traefik 2, fixes #5346 #5647

Merged

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Dec 18, 2023

The Issue

How This PR Solves The Issue

Disables autodetect for Content-Type in Traefik project yaml config.
Note that this fix needs to be reverted when Traefik 3 is out.

Manual Testing Instructions

From #5346 (comment)
I could reproduce it when just created a fresh TYPO3 Install (Apache Webserver) and then in the Backend (Install Tool) under "Environment" and "Environment Status" I get the messages mentioned in my first post. After the changes I mentioned there there are no more unexpected server responses listed.

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

This fix is not needed in the upcoming Traefik 3:

@stasadev stasadev changed the title fix: disable Content-Type auto-detection for Traefik 2, fixes fix: disable Content-Type auto-detection for Traefik 2, fixes #5346 Dec 18, 2023
Copy link

@stasadev stasadev marked this pull request as ready for review December 18, 2023 13:04
@stasadev stasadev requested a review from a team as a code owner December 18, 2023 13:04
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a simple path, but I'm not going to be able to test it or study it. But should be fine. Does it impact docs at all?

@stasadev
Copy link
Member Author

Does not impact docs. This looks like a really rare case.

@stasadev stasadev merged commit f50f1ae into ddev:master Dec 25, 2023
26 checks passed
@stasadev stasadev deleted the 20231218_stasadev_traefik_disable_autodetect branch December 25, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants