Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update global schema #5653

Merged
merged 3 commits into from Dec 25, 2023
Merged

fix: update global schema #5653

merged 3 commits into from Dec 25, 2023

Conversation

tyler36
Copy link
Collaborator

@tyler36 tyler36 commented Dec 20, 2023

The Issue

While editing the global config file, VScode reported 3 invalid keys.

Strangely, after a couple of minutes, the warning disappeared. However, the same 3 keys reported invalid again after a system restart.

The apostrophes also displayed a warning in VSCode:
"The character U+2019 "’" could be confused with the ASCII character U+0060 "`", which is more common in source code."

How This PR Solves The Issue

This PR

  • fixes a single typo.
  • adds the missing keys to the the global schema file.
  • replaces apostrophes with single quote

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

I understand apostrophes vs. single quotes is a personal preference.
My intention is to remove warnings displayed when using the following setting:
"editor.unicodeHighlight.ambiguousCharacters": true,. We can revert that commit, as required.

@tyler36 tyler36 requested a review from a team as a code owner December 20, 2023 02:22
Copy link

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stasadev stasadev merged commit 2e01d29 into ddev:master Dec 25, 2023
26 checks passed
@tyler36 tyler36 deleted the 20231220_schema branch December 27, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants