build: revert bump actions/upload-artifact from 3 to 4, for #5648 #5662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked the build of the master branch, it works https://github.com/ddev/ddev/actions/runs/7340970014 Before merging #5648, I checked in a separate repository that the artifacts appeared on the Checks page and the bot comment looked legitimate, but I didn't click the link to check the artifact itself. I will be more careful about such changes in the future. |
This was referenced Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Go to https://github.com/ddev/ddev/actions/runs/7340705862?pr=5661 and click on the artifact and see:
How This PR Solves The Issue
There is no update guide at the moment, go back to
actions/upload-artifact@v3for now.See
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes