Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure wsl v2 is used, not wsl v1, fixes #5667 [skip ci] #5670

Merged
merged 2 commits into from Jan 4, 2024
Merged

fix: make sure wsl v2 is used, not wsl v1, fixes #5667 [skip ci] #5670

merged 2 commits into from Jan 4, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Jan 2, 2024

The Issue

Prevent people from accidentally using WSL v1

How This PR Solves The Issue

  • Add more to docs about WSL v2
  • Make the automated scripts check for WSL_INTEROPE

Manual Testing Instructions

This requires careful manual checking on a Windows machine, using both WSL v1 and v2.

I may be able to do that but this certainly can't go in without manual testing, so leaving it draft until tested.

@github-actions github-actions bot added the bugfix label Jan 2, 2024
@rfay rfay marked this pull request as ready for review January 2, 2024 23:45
@rfay rfay requested review from a team as code owners January 2, 2024 23:45
@rfay
Copy link
Member Author

rfay commented Jan 2, 2024

I was able to manually test this.

  • WSL v1 distro with each script (properly failed with a message)
  • WSL v2 distro with each script (worked fine)

@rfay rfay requested a review from stasadev January 2, 2024 23:46
stasadev
stasadev approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rfay rfay merged commit 9b30cac into ddev:master Jan 4, 2024
13 checks passed
@rfay rfay deleted the 20240102_wsl_1_prevent branch January 4, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stasadev stasadev stasadev approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rfay @stasadev