Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: temporarily revert docs on not needing --create-docroot #5716

Merged
merged 2 commits into from Jan 19, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Jan 19, 2024

The Issue

People have been stumbling over the fact that --create-docroot is no longer in the quickstarts.. because it's removed in latest dev versions. But it's required in latest stable.

How This PR Solves The Issue

Temporarily revert the changes to the quickstarts and re-add -- create-docroot

This PR should be reverted before the next release.

@rfay rfay marked this pull request as ready for review January 19, 2024 18:43
@rfay rfay requested a review from a team as a code owner January 19, 2024 18:43
@rfay rfay assigned stasadev and unassigned stasadev Jan 19, 2024
@rfay rfay requested a review from stasadev January 19, 2024 18:44
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more for Ibexa DXP:

ddev config --project-type=php --php-version 8.1 --docroot=public

@rfay
Copy link
Member Author

rfay commented Jan 19, 2024

Thanks, fixed that one.

@rfay rfay merged commit 9bd9054 into ddev:master Jan 19, 2024
10 checks passed
@rfay rfay deleted the 20240119_revert_create_docroot_docs branch January 19, 2024 19:03
rfay added a commit that referenced this pull request Feb 2, 2024
rfay added a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants