feat: Platform.sh specific app pull, fixes #5727 #5728
Conversation
…an one app under your env.
nir-riskified
changed the title
nir-riskified
changed the title
nir-riskified
changed the title
There was a problem hiding this comment.
I haven't actually tested platform integration with --app, but I suggest a more elegant way of writing the condition.
Used ${parameter:+word} from https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html
If parameter is null or unset, nothing is substituted, otherwise the expansion of word is substituted.
|
I checked if all changed commands have You can apply my suggestions in one commit on the Files tab. And please update the documentation file when you get a chance. Thank you for the contribution! |
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
|
Hey @stasadev I've applied your suggestions and updated the document file accordingly. Let me know if there's anything else. Thanks for your input!" |
|
Download the artifacts for this pull request:
See Testing a PR |
There was a problem hiding this comment.
@nir-riskified, I like your change in the docs with a new section for multiple apps, let's use it for information about the optional PLATFORM_APP instead of mixing it with other variables.
stasadev
changed the title
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
|
Updated! Thanks @stasadev |
…an one app under your env.
The Issue
Today there is no option to choose an app when pulling data from platform.sh using ddev pull platform
How This PR Solves The Issue
Adding new env variable support PLATFORM_APP, when this variable exists we are adding --app flag
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
#5727
Release/Deployment Notes