docs: Update Drupal 9 & 10 CMS Quickstarts #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ddev drush uli` generates a one-time link to the page for editing the uid1 (admin) account details. If the site is opened with that, there is no need to also run `ddev launch`, so that is confusing. Hence, adding instructions on how to open the link generated by `ddev drush uli`, followed by a reference to `ddev launch` for further visits.
… and stop tests failing
stasadev
approved these changes
Jan 24, 2024
|
A side note: All the other quickstart guides result in the launch of website. For consistency, I would prefer to see the quickstart guide end with |
stasadev
requested changes
Jan 25, 2024
There was a problem hiding this comment.
@tyler36 I agree with standardization.
@Nick-Hope, maybe it can be written like this:
# use the one-time link (CTRL/CMD + Click) from the command below to edit your admin account details.
ddev drush uli
ddev launch
Revert to having `ddev launch` as the last command, but add comment above `ddev drush ul`.
|
A number of approaches here would be acceptable. Decided the @stasadev suggestion was as good as any. |
stasadev
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
ddev drush uligenerates a one-time link to the page for editing the uid1 (admin) account details. If the site is opened with that, there is no need to also runddev launch, so that is confusing.How This PR Solves The Issue
Add instructions on how to open the link generated by
ddev drush uli. Removeddev launchfrom the initial instructions but refer to its use for further site visits.An alternative would be to drop the
ddev drush uliline, but then the user would not be logged in whenddev launchis run.