docs: added sql:sanitize to Drupal hook examples. #5737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, last commit message should say |
stasadev
requested changes
Jan 25, 2024
| @@ -143,24 +151,22 @@ hooks: | |||
| - exec: "drush cc all" | |||
| ``` | |||
|
|
|||
| ## Drupal 8 Example | |||
| ## Drupal 10 Example | |||
There was a problem hiding this comment.
I'm not sure, but isn't "Drupal 8 Example" still relevant for Drupal 8, and "Drupal 10 Example" might have its own section?
There was a problem hiding this comment.
There was command differences between Drupal 7 and Drupal 8 (eg: drush cc all to drush cr) but D8 onwards the commands are the same.
Drupal.org doesn't list Drupal 8 or 9 as current versions (D8 was end of life in 2021 and D9 was November 2023)
so it was just to keep with consistency with the Project.
|
Download the artifacts for this pull request:
See Testing a PR |
stasadev
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
It would be nice to encourage database sanitizing when importing a database to a local environment.
How This PR Solves The Issue
Updated examples to include sql:sanitize to post-import-db hooks for Drupal 10 installations.
Changed example heading from Drupal 8 to Drupal 10 to demonstrate this is the current Drupal version.
Also updated commands to use their full name instead of the alias, for better visibility.