feat: add WSL2 support to tableplus command #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plebward
changed the title
|
Download the artifacts for this pull request:
See Testing a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Add WSL2 support to the ddev tableplus command
Looks like TablePlus have put out a release since the blocking issue was encountered here - #2679 (comment)
How This PR Solves The Issue
Adds a case that launches the Windows version of TablePlus, taking advantage of the WSL2 OS identifier
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes