Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add environment and name to TablePlus command #5741

Merged
merged 1 commit into from Jan 26, 2024

Conversation

marten-wirelab
Copy link
Contributor

The Issue

Running ddev tableplus opens the database tagged as production and without any description of the site being worked on

How This PR Solves The Issue

It adds Environment and Name query parameters to the URI, which TablePlus interprets

Manual Testing Instructions

  • Run ddev tableplus on a project
  • Check out the toolbar, which should now show a green "loc" box and should show the site name

Automated Testing Overview

I don't think this requires any extra testing beyond any pre-existing tests for ddev tableplus

Related Issue Link(s)

  • no known issue

Release/Deployment Notes

  • should not impact anything else

@marten-wirelab marten-wirelab requested a review from a team as a code owner January 26, 2024 09:16
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! To show the change:

Before:
before

After:
after

@stasadev stasadev merged commit 2defedb into ddev:master Jan 26, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants