Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use zero width non joiner for markdownlint #5765

Merged

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Feb 2, 2024

The Issue

Markdownlint has new rule MD056.

And our docs fail with:

MD055/table-pipe-style Table pipe style [Expected: leading_only; Actual: leading_and_trailing; Unexpected trailing pipe]
MD056/table-column-count Table column count [Expected: 3; Actual: 2; Too few cells, row will be missing data]

How This PR Solves The Issue

Uses zero width non joiner ‌ https://en.wikipedia.org/wiki/Zero-width_non-joiner.

I also found and replaced unicode   with a regular space.

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@stasadev stasadev requested a review from a team as a code owner February 2, 2024 15:57
@stasadev stasadev force-pushed the 20240202_stasadev_markdownlint_rule_MD056 branch from 6d99d86 to d4905ed Compare February 2, 2024 16:01
@stasadev stasadev force-pushed the 20240202_stasadev_markdownlint_rule_MD056 branch from d4905ed to d226ffa Compare February 2, 2024 16:08
@stasadev stasadev merged commit c9d8f54 into ddev:master Feb 2, 2024
10 checks passed
@stasadev stasadev deleted the 20240202_stasadev_markdownlint_rule_MD056 branch February 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant