New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace fsouza/go-dockerclient with docker/docker/client, fixes #3460 #5787
feat: replace fsouza/go-dockerclient with docker/docker/client, fixes #3460 #5787
Conversation
Download the artifacts for this pull request:
See Testing a PR |
Wow, he DID IT! |
Great initial news is that trivial manual test works out great, thanks! |
d31628e
to
4e35d4f
Compare
Getting very close if we're only failing when we get to TestCmdVersion ! |
af3e5dd
to
dc0950c
Compare
49f62ee
to
cbb96e3
Compare
The tests are fine, but unfortunately, it's literally impossible to review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on an amazing piece of work, thanks so much!
I think we should get this in as soon as possible so we get maximum experience with it. Just waiting for some sort of stability on master tests right now.
The Issue
How This PR Solves The Issue
Uses
docker/docker/client
instead offsouza/go-dockerclient
.TODO:
github.com/docker/docker/...
imports topkg/dockerutil/dockerutils.go
.Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes