Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace fsouza/go-dockerclient with docker/docker/client, fixes #3460 #5787

Merged
merged 2 commits into from Feb 17, 2024

Conversation

stasadev
Copy link
Member

@stasadev stasadev commented Feb 5, 2024

The Issue

How This PR Solves The Issue

Uses docker/docker/client instead of fsouza/go-dockerclient.

TODO:

  • pass all tests.
  • move all github.com/docker/docker/... imports to pkg/dockerutil/dockerutils.go.
  • deal with Docker context workarounds (maybe not in this PR).

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@github-actions github-actions bot added dependencies Pull requests that update a dependency file enhancement labels Feb 5, 2024
@stasadev stasadev changed the title feat: replace Docker client library, fixes #3460 feat: replace fsouza/go-dockerclient with docker/docker/client, fixes #3460 Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

@rfay
Copy link
Member

rfay commented Feb 5, 2024

Wow, he DID IT!

@rfay
Copy link
Member

rfay commented Feb 5, 2024

Great initial news is that trivial manual test works out great, thanks!

@stasadev stasadev force-pushed the 20240119_stasadev_replace_docker_client branch from d31628e to 4e35d4f Compare February 6, 2024 20:48
@rfay
Copy link
Member

rfay commented Feb 11, 2024

Getting very close if we're only failing when we get to TestCmdVersion !

@stasadev stasadev force-pushed the 20240119_stasadev_replace_docker_client branch from af3e5dd to dc0950c Compare February 14, 2024 17:09
@stasadev stasadev force-pushed the 20240119_stasadev_replace_docker_client branch from 49f62ee to cbb96e3 Compare February 15, 2024 20:20
@stasadev
Copy link
Member Author

The tests are fine, but unfortunately, it's literally impossible to review the changes.
I decided to make two commits: one with the vendor folder and the other with everything else.
This way we can easily review the changes (and we can select several commits to review).

cbb96e3 (#5787)

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on an amazing piece of work, thanks so much!

I think we should get this in as soon as possible so we get maximum experience with it. Just waiting for some sort of stability on master tests right now.

@stasadev stasadev marked this pull request as ready for review February 16, 2024 17:32
@stasadev stasadev requested review from a team as code owners February 16, 2024 17:32
@rfay rfay merged commit b3f7cf6 into ddev:master Feb 17, 2024
25 of 26 checks passed
@stasadev stasadev deleted the 20240119_stasadev_replace_docker_client branch February 19, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants