New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add instructions for Grav CMS to quickstart.md #5796
docs: add instructions for Grav CMS to quickstart.md #5796
Conversation
Would be great to get grav community feedback here. Also, since Grav has long explicitly shown DDEV as their local dev option, link to https://learn.getgrav.org/16/webservers-hosting/local-development-with-ddev |
good point. I wasn't aware of that particular page, but I've extended the last sentence pointing to the page you've raised. thanks! |
the tests are green again now and all styling glitches and typos are fixed. it is ready to be reviewed now. |
This can go just pending manual testing to make sure it works for somebody else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried all the instructions provided, it looks good to me.
I do have a small suggestion regarding git clone
.
remove `--no-dev -o` option from composer install and adding the `ddev launch` i forgot in the first place for the git clone variant - changes based the review from @stasadev Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
786a949
to
8929c34
Compare
The Issue
There were no quickstart guide for Grav CMS
How This PR Solves The Issue
It is adding instructions for a composer based install and a git clone based on to the quickstart.md
Manual Testing Instructions
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes