Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add instructions for Grav CMS to quickstart.md #5796

Merged
merged 6 commits into from Feb 28, 2024

Conversation

rpkoller
Copy link
Collaborator

@rpkoller rpkoller commented Feb 7, 2024

The Issue

There were no quickstart guide for Grav CMS

How This PR Solves The Issue

It is adding instructions for a composer based install and a git clone based on to the quickstart.md

Manual Testing Instructions

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

@rpkoller rpkoller requested a review from a team as a code owner February 7, 2024 16:43
@rfay
Copy link
Member

rfay commented Feb 7, 2024

Would be great to get grav community feedback here. Also, since Grav has long explicitly shown DDEV as their local dev option, link to https://learn.getgrav.org/16/webservers-hosting/local-development-with-ddev

@rpkoller rpkoller requested a review from a team as a code owner February 7, 2024 16:55
@rpkoller
Copy link
Collaborator Author

rpkoller commented Feb 7, 2024

Would be great to get grav community feedback here. Also, since Grav has long explicitly shown DDEV as their local dev option, link to https://learn.getgrav.org/16/webservers-hosting/local-development-with-ddev

good point. I wasn't aware of that particular page, but I've extended the last sentence pointing to the page you've raised. thanks!

@rpkoller
Copy link
Collaborator Author

rpkoller commented Feb 7, 2024

the tests are green again now and all styling glitches and typos are fixed. it is ready to be reviewed now.

@stasadev stasadev self-requested a review February 26, 2024 17:41
@rfay
Copy link
Member

rfay commented Feb 26, 2024

This can go just pending manual testing to make sure it works for somebody else.

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried all the instructions provided, it looks good to me.
I do have a small suggestion regarding git clone.

docs/content/users/quickstart.md Outdated Show resolved Hide resolved
rpkoller and others added 6 commits February 28, 2024 00:00
remove `--no-dev -o` option from composer install and adding the `ddev launch` i forgot in the first place for the git clone variant - changes based the review from @stasadev

Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
@rpkoller rpkoller force-pushed the 20240207-rpkoller-add-grav-quickstart branch from 786a949 to 8929c34 Compare February 27, 2024 23:00
@rfay rfay merged commit 751b6a5 into ddev:master Feb 28, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants