build: bump traefik to 2.11 #5833

nilsingwersen · 2024-02-13T10:37:26Z

The Issue

Traefik got updated to version 2.11.

Summary by CodeRabbit

New Features
- Updated Traefik to version 2.11 for improved routing capabilities.
- Added monitoring capabilities with the TRAEFIK_MONITOR_PORT set to 10999.
- Enhanced container with utility tools (bash, curl, htop, vim) for better troubleshooting and debugging experience.

rfay · 2024-02-13T14:36:16Z

Thanks for tracking this @nilsandresen ! We can sure try this out. It does require pushing an image. I'll see if I can do that.

I'm interested to know why you're paying such good attention. Is there something you're looking for in 2.11? (I saw the release go by, but didn't read carefully and actually thought we were tracking 2.x)

rfay · 2024-02-13T14:42:31Z

Rebased, updated reference, pushed the image, tests are running, thanks.

coderabbitai · 2024-02-13T14:42:40Z

Walkthrough

The recent update involves upgrading the ddev-traefik-router to utilize Traefik version 2.11, enhancing its routing capabilities. Additionally, the update enriches the container's environment by setting a monitoring port and installing essential utilities like bash, curl, htop, and vim. Moreover, the version tag for the TraefikRouterImage in the project's version constants has been refreshed to reflect the new Traefik version and the current date.

Changes

File Path	Change Summary
`containers/.../Dockerfile`	Updated to Traefik 2.11, set `TRAEFIK_MONITOR_PORT` to `10999`, installed `bash`, `curl`, `htop`, `vim`
`pkg/.../versionconstants.go`	Updated `TraefikRouterImage` tag to `20240213_traefik_2.11`

🐇✨
In a world of code and docker files,
A rabbit hops, bringing updates with smiles.
"To Traefik 2.11, we leap!" it said,
With tools in hand, and forward we tread.
🚀💫

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 3a1bcf9 and ffe2b50.

Files selected for processing (2)

containers/ddev-traefik-router/Dockerfile (1 hunks)
pkg/versionconstants/versionconstants.go (1 hunks)

Additional comments: 3

containers/ddev-traefik-router/Dockerfile (2)

1-1: Ensure all dependent configurations and features are compatible with Traefik version 2.11.

2-2: Setting TRAEFIK_MONITOR_PORT to 10999 is clear. Verify this port does not conflict with other services.

pkg/versionconstants/versionconstants.go (1)

27-27: The update to TraefikRouterImage is consistent with the Traefik version upgrade. Verify its usage across the project.

coderabbitai · 2024-02-13T14:44:26Z

containers/ddev-traefik-router/Dockerfile

@@ -1,4 +1,4 @@
-FROM traefik:2.10
+FROM traefik:2.11

 ENV TRAEFIK_MONITOR_PORT=10999


Installing bash, curl, htop, and vim increases utility but also image size. Consider if all are necessary.

containers/ddev-traefik-router/Dockerfile

github-actions · 2024-02-13T14:45:30Z

Download the artifacts for this pull request:

See Testing a PR

nilsingwersen · 2024-02-13T14:52:54Z

@rfay We are using traefik as a router for some docker containers and I ran updates there today. Then I remembered the ddev router runs on traefik aswell and I thought why not open a PR.

rfay · 2024-02-13T14:53:49Z

Thanks @nilsandresen - Do you do any custom config of traefik in DDEV? I always love to hear how people are using this feature.

rfay · 2024-02-13T14:55:04Z

I also see that 3.0.0 is at rc1 status, and wonder what that will mean to us. We may want to get 3.0.0 in before DDEV v1.23.0, which is coming in the next couple of months.

nilsingwersen · 2024-02-13T15:16:50Z

Thanks @nilsandresen - Do you do any custom config of traefik in DDEV? I always love to hear how people are using this feature.

In DDEV not, I use traefik outside of DDEV aswell. I'm using it as reverse proxy with automatic SSL Certs.

nilsingwersen · 2024-02-13T15:17:20Z

I also see that 3.0.0 is at rc1 status, and wonder what that will mean to us. We may want to get 3.0.0 in before DDEV v1.23.0, which is coming in the next couple of months.

Traefik 3 hast been cooking for a long time and I don't think it will be released soon.

rfay · 2024-02-13T15:26:22Z

In DDEV not, I use traefik outside of DDEV aswell. I'm using it as reverse proxy with automatic SSL Certs

One of the key things that hasn't been studied in DDEV with traefik is using Let's Encrypt, so the old nginx-proxy router recipe is still what I and other people are using. Would love to have you take a look at this if you're interested, https://ddev.readthedocs.io/en/latest/users/topics/hosting/

nilsingwersen · 2024-02-13T15:38:13Z

In DDEV not, I use traefik outside of DDEV aswell. I'm using it as reverse proxy with automatic SSL Certs

One of the key things that hasn't been studied in DDEV with traefik is using Let's Encrypt, so the old nginx-proxy router recipe is still what I and other people are using. Would love to have you take a look at this if you're interested, https://ddev.readthedocs.io/en/latest/users/topics/hosting/

Yeah I might take a look. If I found out something interesting should I share it on discord, or a discussion?

rfay · 2024-02-13T15:47:47Z

Just open a PR! Thanks! Happy to discuss it anywhere though.

rfay

Looks good, tests are good, thanks!

nilsingwersen requested a review from a team as a code owner February 13, 2024 10:37

This comment was marked as off-topic.

Sign in to view

nilsingwersen changed the title ~~Bump traefik to 2.11~~ build: bump traefik to 2.11 Feb 13, 2024

github-actions bot added the maintenance label Feb 13, 2024

nilsingwersen force-pushed the 20240213_traefik_2.11 branch from e8ee541 to 04639c2 Compare February 13, 2024 11:08

This comment was marked as off-topic.

Sign in to view

ddev deleted a comment from coderabbitai bot Feb 13, 2024

nilsingwersen and others added 2 commits February 13, 2024 07:41

build: bump traefik to 2.11

2d91b5e

bump used image reference

ffe2b50

rfay force-pushed the 20240213_traefik_2.11 branch from 04639c2 to ffe2b50 Compare February 13, 2024 14:42

github-actions bot added the dependencies Pull requests that update a dependency file label Feb 13, 2024

coderabbitai bot reviewed Feb 13, 2024

View reviewed changes

rfay approved these changes Feb 14, 2024

View reviewed changes

rfay merged commit 0f21004 into ddev:master Feb 14, 2024
22 of 23 checks passed

nilsingwersen deleted the 20240213_traefik_2.11 branch February 14, 2024 05:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: bump traefik to 2.11 #5833

build: bump traefik to 2.11 #5833

nilsingwersen commented Feb 13, 2024 •

edited by coderabbitai bot

This comment was marked as off-topic.

This comment was marked as off-topic.

rfay commented Feb 13, 2024

rfay commented Feb 13, 2024

coderabbitai bot commented Feb 13, 2024 •

edited

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

coderabbitai bot Feb 13, 2024

github-actions bot commented Feb 13, 2024

nilsingwersen commented Feb 13, 2024

rfay commented Feb 13, 2024

rfay commented Feb 13, 2024

nilsingwersen commented Feb 13, 2024

nilsingwersen commented Feb 13, 2024

rfay commented Feb 13, 2024

nilsingwersen commented Feb 13, 2024

rfay commented Feb 13, 2024

rfay left a comment

build: bump traefik to 2.11 #5833

build: bump traefik to 2.11 #5833

Conversation

nilsingwersen commented Feb 13, 2024 • edited by coderabbitai bot

The Issue

Summary by CodeRabbit

This comment was marked as off-topic.

This comment was marked as off-topic.

rfay commented Feb 13, 2024

rfay commented Feb 13, 2024

coderabbitai bot commented Feb 13, 2024 • edited

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Feb 13, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 13, 2024

nilsingwersen commented Feb 13, 2024

rfay commented Feb 13, 2024

rfay commented Feb 13, 2024

nilsingwersen commented Feb 13, 2024

nilsingwersen commented Feb 13, 2024

rfay commented Feb 13, 2024

nilsingwersen commented Feb 13, 2024

rfay commented Feb 13, 2024

rfay left a comment

Choose a reason for hiding this comment

nilsingwersen commented Feb 13, 2024 •

edited by coderabbitai bot

coderabbitai bot commented Feb 13, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)