fix: error message 'Error converting to int' on ddev import-db
#5856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
|
The problem here is that Innodb_rows_inserted was removed in MariaDB 10.10, https://mariadb.com/kb/en/innodb-status-variables/#innodb_rows_inserted |
rfay
force-pushed
the
20240216_remove_output_Error_converting_to_int
branch
from
24beb8a
to
a2a7b19
Compare
rfay
changed the title
ddev import-db
stasadev
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
I've been noticing in tests and in manual testing of
ddev import-dbthe message "Error converting '' to int":How This PR Solves The Issue
Allow empty and don't try to convert it to a zero. I'm not sure this is a change in go's behavior.
I was unable to find a replacement technique for this stanza. The original idea was to watch the rows come in until they stopped coming in. I don't see how to do that now. But I did my traditional huge database import-db and it seemed to work fine.
Manual Testing Instructions
ddev import-dbshouldn't show thisddev import-dbis behaving OK on huge db import, which is what this code is for.Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes