Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mostly warn people off of using xdebug_ide_location #5857

Merged
merged 4 commits into from Feb 17, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Feb 17, 2024

The Issue

A user in Discord set xdebug_ide_location to container and didn't know why it didn't work

How This PR Solves The Issue

Try to get people not to use it except in the obscure situations it's needed for.

@@ -666,7 +666,7 @@ Whether Xdebug should be enabled for [step debugging](../debugging-profiling/ste

## `xdebug_ide_location`

Adjust Xdebug listen location for WSL2 or in-container.
Adjust Xdebug listen location for WSL2 or in-container. This is used very rarely, please don't change it unless you really know why.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Adjust Xdebug listen location for WSL2 or in-container. This is used very rarely, please don't change it unless you really know why.
Adjust Xdebug listen location for WSL2 or in-container. This is used very rarely, please don't change it unless you really know what you're doing.

Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to add something like "seek advice in one of our support channels before making any of these changes unless you really know what you're doing" and link to https://ddev.com/support-ddev/#help-others or similar location

@rfay rfay force-pushed the 2240216_better_warning_about_xdebug_ide_location branch from 898d83a to ea4e55a Compare February 17, 2024 15:21
@rfay rfay marked this pull request as ready for review February 17, 2024 15:22
@rfay rfay requested a review from a team as a code owner February 17, 2024 15:22
@rfay rfay merged commit 49bf2a4 into master Feb 17, 2024
15 checks passed
@rfay rfay deleted the 2240216_better_warning_about_xdebug_ide_location branch February 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants