fix: don't start 'mutagen daemon run' during ddev stop/delete #5868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR |
stasadev
requested changes
Feb 19, 2024
stasadev
approved these changes
Feb 19, 2024
Co-authored-by: Stanislav Zhuk <stasadev@gmail.com>
rfay
force-pushed
the
20240219_dont_accidentally_start_mutagen
branch
from
39d5a95
to
96daab6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
In testing a completely unrelated issue on Linux/WSL2, I happened to notice that
mutagen daemon runwas running (ps -ef |grep mutagen) even though nothing in the system hadperformance_mode: mutagen.It turned out that SyncAndPauseMutagenSession() and TerminateMutagenSession() were not protected by app.IsMutagenEnabled(), and even though their activities didn't cause trouble, there was the side-effect of starting the mutagen daemon, which is not needed.
How This PR Solves The Issue
Properly protect against use of those functions in non-mutagen setup.
Manual Testing Instructions
With mutagen disabled
mutagen daemon runisn't runningddev start,ddev stop,ddev poweroff,ddev delete- none of these should result in the mutagen daemon runningAutomated Testing Overview
Related Issue Link(s)
Release/Deployment Notes