Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't panic in app.Describe() if container not found #5873

Merged
merged 1 commit into from Feb 21, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Feb 20, 2024

The Issue

This is secondary to the actual problem we're chasing there, but there is no reason to do a panic in this situation.

How This PR Solves The Issue

  • Replace util.CheckErr() with a warning
  • Remove a second util.CheckErr() which was checking the same err

Copy link

@rfay rfay marked this pull request as ready for review February 21, 2024 13:50
@rfay rfay requested a review from a team as a code owner February 21, 2024 13:50
@rfay rfay merged commit 8f7a15d into ddev:master Feb 21, 2024
21 of 22 checks passed
@rfay rfay deleted the 20240219_fix_panic branch February 21, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant