Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make sure buildkite leaves docker in sane setup #5897

Merged
merged 17 commits into from Feb 26, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Feb 26, 2024

The Issue

We're having a little trouble with buildkite/macos cleanup, especially when it seems like Colima doesn't start right

How This PR Solves The Issue

Try to simplify the startup clean situation

  • Make sure everything is stopped, then orbstack or Docker Desktop (or some docker provider) running
  • Make sure we are on a context with docker running

.buildkite/test.sh Outdated Show resolved Hide resolved
.buildkite/test.sh Outdated Show resolved Hide resolved
.buildkite/test.sh Outdated Show resolved Hide resolved
@rfay rfay marked this pull request as ready for review February 26, 2024 16:57
@rfay rfay requested a review from a team as a code owner February 26, 2024 16:57
@rfay rfay changed the title test: make sure buildkite leaves docker in predictable setup test: make sure buildkite leaves docker in sane setup Feb 26, 2024
@rfay rfay merged commit 3c07de8 into ddev:master Feb 26, 2024
14 of 17 checks passed
@rfay rfay deleted the 20240225_buildkite_cleanup branch February 26, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants