Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Pimcore quickstart, fixes #5843 #5909

Merged
merged 4 commits into from Mar 1, 2024

Conversation

rfay
Copy link
Member

@rfay rfay commented Feb 28, 2024

The Issue

We'll want more input from the Pimcore community, but this adds a basic quickstart.

Docs example at https://ddev--5909.org.readthedocs.build/en/5909/users/quickstart/#pimcore

@rfay rfay requested a review from gilzow February 28, 2024 17:02
@rfay rfay mentioned this pull request Feb 28, 2024
@rfay rfay marked this pull request as ready for review February 28, 2024 17:12
@rfay rfay requested review from a team as code owners February 28, 2024 17:12
@rfay rfay requested a review from rpkoller February 28, 2024 17:12
@rfay
Copy link
Member Author

rfay commented Feb 28, 2024

@80982proton would love to have your review here.

@SuperFlySly
Copy link

Looks good so far, there are still some fine details which you will have to install yourself! There is also the "symfony consumer command" that you have to start! https://github.com/pimcore/skeleton/blob/11.x/.docker/supervisord.conf

Bildschirm­foto 2024-02-28 um 20 14 31

@rfay
Copy link
Member Author

rfay commented Feb 28, 2024

@SuperFlySly could you please be explicit about

there are still some fine details which you will have to install yourself

Were you just referring to the "Recommended but not required" things in your screenshot? Should we be telling them how to do everything?

We can add the symfony consumer command with web_extra_daemons I guess (that installs in supervisord)

rfay and others added 3 commits February 29, 2024 08:52
Co-authored-by: Ralf Koller <1665422+rpkoller@users.noreply.github.com>
@rfay rfay force-pushed the 20240228_pimcore_quickstart branch from c9baad6 to 74b18ec Compare February 29, 2024 15:52
@rfay rfay force-pushed the 20240228_pimcore_quickstart branch from 74b18ec to 2ac0543 Compare February 29, 2024 16:05
@rfay
Copy link
Member Author

rfay commented Feb 29, 2024

@SuperFlySly I've added the consumer as web_extra_daemon, would love your review again.

It looks to me like the other "recommended" things aren't something that would need to be done in a "quickstart", true?

@rfay
Copy link
Member Author

rfay commented Feb 29, 2024

Related: Pimcore additional tools installation

@rfay
Copy link
Member Author

rfay commented Mar 1, 2024

I'm going to go with this, and we'll learn from the Pimcore community as they arrive! Thanks for the help everybody.

@rfay rfay merged commit 9e31187 into ddev:master Mar 1, 2024
10 checks passed
@rfay rfay deleted the 20240228_pimcore_quickstart branch March 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants